feat: add avro reader to registry #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
approved these changes
Jun 30, 2025
dongxiao1198
approved these changes
Jul 1, 2025
mapleFU
approved these changes
Jul 1, 2025
| using Data = | ||
| std::variant<std::monostate, ArrowArray, std::reference_wrapper<const StructLike>>; | ||
| virtual Result<Data> Next() = 0; | ||
| /// \return std::nullopt if the reader has no more data, otherwise `ArrowArray`. |
There was a problem hiding this comment.
Minor: can ArrowArray be empty? Does empty array means ending? Or it can have data left?
There was a problem hiding this comment.
The contract of ArrowArray is that data can be empty but it does not mean the end of file.
Xuanwo
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.